Refactor testTimestampCoercion in Delta Lake connector #25676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpro1011
changed the title
ebyhr
reviewed
Apr 25, 2025
| ('url5', 'domain2', 500), | ||
| ('url6', 'domain4', 2) | ||
| """); | ||
| """ |
There was a problem hiding this comment.
Please revert unrelated changes. Same for other places.
There was a problem hiding this comment.
I've reverted the formatting changes and ensured the diff is now clean. Let me know if you see anything else I should update. Thanks!
danpro1011
force-pushed
the
refactor-timestamp-tests
branch
from
82f009a to
4b4fef1
Compare
danpro1011
force-pushed
the
refactor-timestamp-tests
branch
from
4b4fef1 to
a7568e4
Compare
| { | ||
| return typeCoercionTimestamp().stream() | ||
| .filter(setup -> !isNestedType(setup.newColumnType())) | ||
| .collect(toList()); |
There was a problem hiding this comment.
Use toImmutableList()
| for (TypeCoercionTestSetup setup : typeCoercionTimestampProvider()) { | ||
| try (TestTable testTable = newTrinoTable( | ||
| "test_timestamp_coercion_on_create_table", | ||
| "(ts %s)".formatted(setup.newColumnType))) { |
There was a problem hiding this comment.
We are testing coercion here, so the create type shouldn't same as the insert type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the
testTimestampCoercion*methods inTestDeltaLakeConnectorTestto use the sharedTypeCoercionTestSetuprecord, improving consistency with Iceberg connector tests. It also includes a test case for coercion involving nested types such asarray(array(...)), as requested.Additional context and related issues
Follows the approach used in Iceberg’s
BaseIcebergConnectorTest.Improves clarity and maintainability of timestamp coercion tests for the Delta Lake connector.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.