Add missing unit tests on Faker queries #24540
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerQueries.java
Outdated
Show resolved
Hide resolved
plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerQueries.java
Outdated
Show resolved
Hide resolved
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerQueries.java
Outdated
Show resolved
Hide resolved
plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerQueries.java
Outdated
Show resolved
Hide resolved
plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerQueries.java
Outdated
Show resolved
Hide resolved
| @@ -15,6 +15,7 @@ | |||
| package io.trino.plugin.faker; | |||
|
|
|||
| import com.google.common.collect.ImmutableList; | |||
| import com.google.common.collect.ImmutableMap; | |||
There was a problem hiding this comment.
Add missing unit tests on Faker queries
The commit message is misleading when it changes the product code.
There was a problem hiding this comment.
Went with it, because unit tests forced the fixes on product code.
Do you have any suggestions?
There was a problem hiding this comment.
The commit message should say what behavior was fixed. If there are any additional tests, you could extract them into a separate commit. This could make reviewing easier, but it's optional.
I assume you started with the intention of only adding tests, and this is expressed in the current commit message. Then noticed the code needs to be fixed, so you did that to make the tests passed. You should update the commit message to reflect the end result.
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
github-actions
bot
added
iceberg
Description
Fixes #23911
Add missing unit tests to Faker connector methods renameTable, setTableProperties and setTableComment.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.