Fix handling of hidden objects in migration during add_files/add_files_from_table #24092
+59
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Nov 10, 2024
uditvarshney
force-pushed
the
migrationFix
branch
from
de8ef15
to
b2405bc
Compare
uditvarshney
force-pushed
the
migrationFix
branch
from
b2405bc
to
34d65a5
Compare
Added the test cases |
ebyhr
requested changes
Nov 12, 2024
| @@ -109,7 +109,7 @@ public static List<DataFile> buildDataFiles( | |||
| FileEntry file = files.next(); | |||
| String fileLocation = file.location().toString(); | |||
| String relativePath = fileLocation.substring(location.length()); | |||
| if (relativePath.contains("/_") || relativePath.contains("/.")) { | |||
| if (relativePath.contains("/_") || fileLocation.contains("/.")) { | |||
There was a problem hiding this comment.
This change seems wrong. Hive doesn't ignore files where the parent directory starts with . as far as I know.
The reason we used relativePath here was ignoring files under the table location.
You can investigate Hive behavior with S3HiveQueryRunner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 23891
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: