Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotating CI run when product tests fail #23499

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

nineinchnick
Copy link
Member

Description

The product tests job test step should have an ID used to check if it failed, so its test reports can be processed and annotations can be generated.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

The product tests job test step should have an ID used to check if it
failed, so its test reports can be processed and annotations can be
generated.
.github/workflows/ci.yml Show resolved Hide resolved
@wendigo
Copy link
Contributor

wendigo commented Sep 19, 2024

@nineinchnick there is no annotation here

@nineinchnick
Copy link
Member Author

nineinchnick commented Sep 19, 2024

I think this is because the environment failed to start, and it didn't even run any tests. If tempto was not started, it couldn't have generated any testng-report.xml file:

2024-09-19T10:17:41.626Z	INFO	main	io.trino.tests.product.launcher.env.Environment	Environment 'multinode-sqlserver' failed to start in attempt(s): 6: java.lang.RuntimeException: java.util.concurrent.ExecutionException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image mcr.microsoft.com/mssql/server:2017-latest
2024-09-19T10:17:41.626Z	WARN	main	io.trino.tests.product.launcher.cli.TestRun	Failed to execute tests
java.lang.RuntimeException: java.util.concurrent.ExecutionException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image mcr.microsoft.com/mssql/server:2017-latest

This should not block us from merging this PR.

@wendigo wendigo merged commit 4e0969a into trinodb:master Sep 19, 2024
91 of 93 checks passed
@nineinchnick nineinchnick deleted the annotate-when-pts-fail branch September 19, 2024 13:05
@github-actions github-actions bot added this to the 459 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants