Verify user-visible message in assertQueryFails #20661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
test
no-release-notes
losipiuk
approved these changes
Feb 12, 2024
findepi
force-pushed
the
findepi/assert-top-level
branch
from
89ab5bf to
5e8d7e2
Compare
|
previous CI run, hive-tests (config-hdp3) failed at #20625 |
Add dedicated tests for `assertQueryFails`.
findepi
force-pushed
the
findepi/assert-top-level
branch
from
5e8d7e2 to
e6bc986
Compare
ebyhr
approved these changes
Feb 13, 2024
Comment on lines
153
to
154
| String sql = "SELECT CAST('abc' AS date)"; | ||
| String lastMessage; |
Change `assertQueryFails` so that it verifies the message that the end-user would see. Before the change, `assertQueryFails` would accept any TrinoException that has expected message somewhere in the causal chain. However, causal chain may or may not be visible to the end user, depending on the tooling used. This restores the behavior that used to be before commit 0a56d09. Tests that want to verify causal message should do this explicitly.
findepi
force-pushed
the
findepi/assert-top-level
branch
from
80b0d14 to
ff973a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
assertQueryFailsso that it verifies the message that theend-user would see. Before the change,
assertQueryFailswould acceptany TrinoException that has expected message somewhere in the causal
chain. However, causal chain may or may not be visible to the end user,
depending on the tooling used. This restores the behavior that used to
be before commit 0a56d09 (#20048).
Tests that want to verify causal message should do this explicitly.