Specialize batched column-wise hashing for RunLengthEncodedBlock #19723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettyjamesm
force-pushed
the
specialize-rle-hash-strategies
branch
from
5fa972a to
658ac5f
Compare
dain
reviewed
Nov 13, 2023
core/trino-main/src/main/java/io/trino/operator/FlatHashStrategyCompiler.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/FlatHashStrategyCompiler.java
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/operator/TestFlatHashStrategy.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/FlatHashStrategyCompiler.java
Outdated
Show resolved
Hide resolved
pettyjamesm
force-pushed
the
specialize-rle-hash-strategies
branch
from
a9abe87 to
7d37786
Compare
pettyjamesm
force-pushed
the
specialize-rle-hash-strategies
branch
from
7d37786 to
9ac52d5
Compare
dain
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds special case handling of
RunLengthEncodedBlockin generatedFlatHashStrategyimplementations that hoists the hash calculation outside of the loop. This has the added benefit of making the normal compute loop at most bi-morphic betweenDictionaryBlockand the type-correspondingValueBocksubclass.FlatGroupByHashalready specializes hash calculations forRunLengthEncodedBlockat a higher level when all group by input blocks are run-length encoded, so this change will only affect performance for mutli-column grouping operations with a mix of run length and dictionary/plain block inputs.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: