Fixed bug where banner appears instead of indicative message in routing rules page #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoeyoOgen
force-pushed
the
bugfix/fixing_external_service_resource_ui
branch
from
4ed856b to
1be2cc6
Compare
…page for external service
RoeyoOgen
force-pushed
the
bugfix/fixing_external_service_resource_ui
branch
from
1be2cc6 to
f1ba0b0
Compare
RoeyoOgen
changed the title
| @@ -160,7 +163,7 @@ public Response getDistribution(QueryDistributionRequest query) | |||
| Map<String, List<DistributionResponse.LineChart>> lineChartMap = lineChart.stream().collect(Collectors.groupingBy(DistributionResponse.LineChart::getName)); | |||
| List<DistributionResponse.DistributionChart> distributionChart = lineChartMap.values().stream().map(d -> { | |||
| DistributionResponse.DistributionChart dc = new DistributionResponse.DistributionChart(); | |||
| DistributionResponse.LineChart lc = d.get(0); | |||
| DistributionResponse.LineChart lc = d.getFirst(); | |||
There was a problem hiding this comment.
Ensure that 'd.getFirst()' is a valid method for the collection type of 'd'. If this collection is a standard List, use 'd.get(0)' instead.
Suggested change
| DistributionResponse.LineChart lc = d.getFirst(); | |
| DistributionResponse.LineChart lc = d.get(0); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
This change was suggested by the Intelij IDE so changed, really have no opinion in the matter
|
Quickly skimmed through this. I'm fine with it |
ebyhr
requested changes
Apr 14, 2025
| @@ -76,6 +77,7 @@ public class GatewayWebAppResource | |||
| // TODO Avoid putting mutable objects in fields | |||
| private final UIConfiguration uiConfiguration; | |||
| private final RoutingRulesManager routingRulesManager; | |||
| private final HaGatewayConfiguration haGatewayConfiguration; | |||
There was a problem hiding this comment.
Please don't put mutable object in fields.
| @@ -92,6 +94,7 @@ public GatewayWebAppResource( | |||
| this.resourceGroupsManager = requireNonNull(resourceGroupsManager, "resourceGroupsManager is null"); | |||
| this.uiConfiguration = configuration.getUiConfiguration(); | |||
| this.routingRulesManager = requireNonNull(routingRulesManager, "routingRulesManager is null"); | |||
| this.haGatewayConfiguration = configuration; | |||
| @@ -160,7 +163,7 @@ public Response getDistribution(QueryDistributionRequest query) | |||
| Map<String, List<DistributionResponse.LineChart>> lineChartMap = lineChart.stream().collect(Collectors.groupingBy(DistributionResponse.LineChart::getName)); | |||
| List<DistributionResponse.DistributionChart> distributionChart = lineChartMap.values().stream().map(d -> { | |||
| DistributionResponse.DistributionChart dc = new DistributionResponse.DistributionChart(); | |||
| DistributionResponse.LineChart lc = d.get(0); | |||
| DistributionResponse.LineChart lc = d.getFirst(); | |||
There was a problem hiding this comment.
Please separate a commit. This change is unrelated to "Fixed bug in UI where non indicative banner appears in routing rules page for external service".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI Improvements: Fixed bug where banner appears instead of indicative message in routing rules page
Changes
Impact
( X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: