Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorial/fixfrombranch #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Tutorial/fixfrombranch #20

wants to merge 2 commits into from

Conversation

zamrokk
Copy link

@zamrokk zamrokk commented Jan 29, 2025

No description provided.

timothymcmackin
timothymcmackin reviewed Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@timothymcmackin timothymcmackin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix to etherlink-marketpulse/test/Marketpulse.ts works for me, but did you mean to commit changes to artifacts/ and cache/?

@zamrokk
Copy link
Author

zamrokk commented Jan 29, 2025

I believe these 2 folders are generated by hardhat

@timothymcmackin
Copy link
Collaborator

I believe these 2 folders are generated by hardhat

Yes, cache and artifacts are in the .gitignore file I got from hardhat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothymcmackin timothymcmackin timothymcmackin left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zamrokk @timothymcmackin