Zoltan2: Don't access DualView's [h|d]_view directly #13787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
egboman
approved these changes
Feb 12, 2025
|
@masterleinad Same DCO issue here. |
Signed-off-by: Daniel Arndt <[email protected]>
masterleinad
force-pushed
the
zoltan2_access_h_d_view
branch
from
c8cb10c to
4f2f753
Compare
Fixed. Sorry, I'm not very used to signing-off on commits. |
cgcgcg
approved these changes
Feb 13, 2025
|
No worries :-) |
cgcgcg
added
pkg: Zoltan2
AT: PRE-TEST INSPECTED
trilinos-autotester
removed
the
AT: PRE-TEST INSPECTED
|
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed. |
|
Status Flag 'Pull Request AutoTester' - Failure: Job PR_gcc-openmpi-openmp on Jenkins server at https://do.sandia.gov/trilinos-ci Does Not Exist
|
achauphan
added
the
AT: RETEST
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: masterleinad |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
trilinos-autotester
removed
the
AT: RETEST
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ egboman cgcgcg ]! |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
cgcgcg
added
the
AT: AUTOMERGE
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 13787: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 13787: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 13787: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Cannot Merge Pull Request# 13787: Github Mergeability = blocked; Git Mergeable = True |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 13787: IS A SUCCESS - Pull Request successfully merged |
trilinos-autotester
removed
the
AT: AUTOMERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/zoltan2
Motivation
kokkos/kokkos#7716 proposes to deprecate the ability to access
DualView'sh_viewandd_viewmembers directly since modifying the allocations can get perturbed theDualView's internal status. This pull request replaces all places inZoltan2that use these members directly, in most places, verbatim withview_deviceresp.view_host.Related Issues
Related to kokkos/kokkos#7716.
Signed-off-by: Daniel Arndt [email protected]