fix: aggregate compacts before calculations

trifle-io · May 8, 2024 · e06ed26 · e06ed26
1 parent 2b46567
commit e06ed26
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/lib/trifle/stats/aggregator/max.rb b/lib/trifle/stats/aggregator/max.rb
@@ -15,7 +15,9 @@ def aggregate(series:, path:, slices: 1)
         end
 
         def sliced(result:, slices:)
-          result[(result.count - (result.count / slices * slices))..].each_slice(result.count / slices).map(&:max)
+          result[(result.count - (result.count / slices * slices))..].each_slice(result.count / slices).map do |slice|
+            slice.compact.max
+          end
         end
       end
     end

diff --git a/lib/trifle/stats/aggregator/min.rb b/lib/trifle/stats/aggregator/min.rb
@@ -15,7 +15,9 @@ def aggregate(series:, path:, slices: 1)
         end
 
         def sliced(result:, slices:)
-          result[(result.count - (result.count / slices * slices))..].each_slice(result.count / slices).map(&:min)
+          result[(result.count - (result.count / slices * slices))..].each_slice(result.count / slices).map do |slice|
+            slice.compact.min
+          end
         end
       end
     end

diff --git a/lib/trifle/stats/aggregator/sum.rb b/lib/trifle/stats/aggregator/sum.rb
@@ -15,7 +15,9 @@ def aggregate(series:, path:, slices: 1)
         end
 
         def sliced(result:, slices:)
-          result[(result.count - (result.count / slices * slices))..].each_slice(result.count / slices).map(&:sum)
+          result[(result.count - (result.count / slices * slices))..].each_slice(result.count / slices).map do |slice|
+            slice.compact.sum
+          end
         end
       end
     end