Disable network access for the containers #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squell
approved these changes
Jan 13, 2025
bjorn3
force-pushed
the
docker_net_none
branch
from
a3b9886 to
1aaaa2e
Compare
squell
approved these changes
Jan 13, 2025
Turns out setting up a network namespace and reconfiguring the firewall is pretty expensive. Disabling this setup brings down test times from ~210s to ~65s.
bjorn3
force-pushed
the
docker_net_none
branch
from
1aaaa2e to
b9f5100
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out setting up a network namespace and reconfiguring the firewall is pretty expensive. Disabling this setup brings down test times from ~210s to ~65s.