-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement DSL #934
Merged
Merged
Reimplement DSL #934
+353
−378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squell
force-pushed
the
reimplement-dsl
branch
from
December 16, 2024 10:02
148e6fc
to
21585ee
Compare
bjorn3
reviewed
Dec 16, 2024
squell
force-pushed
the
reimplement-dsl
branch
6 times, most recently
from
December 16, 2024 17:06
d38696e
to
4ec4c1a
Compare
This is more 'statically' typed, e.g. no more need for 'late unwraps' whose success can only be determined by careful programming, i.e. a defaults::Settings behaves more like Rust-struct whereas the curent sudoers::Settings behaves like a Python structs.
squell
force-pushed
the
reimplement-dsl
branch
from
December 16, 2024 17:06
4ec4c1a
to
6224bd3
Compare
squell
added
C-checker
Permission checking logic
C-parser
Parser/AST
suggestion
and removed
C-checker
Permission checking logic
suggestion
labels
Dec 18, 2024
bjorn3
reviewed
Jan 6, 2025
bjorn3
reviewed
Jan 6, 2025
Co-authored-by: bjorn3 <[email protected]>
squell
force-pushed
the
reimplement-dsl
branch
from
January 6, 2025 16:44
d3518ce
to
3d9beb2
Compare
bjorn3
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #933
This also isolates all the 'Defaults'-behaviour in the defaults crate, making the exact behaviour of each individual
Defaults
setting irrelevant to the way the parser and semantic analysis handles them. This simplifies those parts.The DSL definition itself also feels a little less magical (although there's some
syntax-rules
hacks there, it's slightly more "regular").E.g. it now generates:
And
impl
sDefault
for this struct, as well as define afn negate
andfn set
that construct an object of the typepub type SettingsModifier = Box<dyn FnOnce(&mut Settings)>;
. E.g.,Note also that the enum-like sudoers settings are turned into an actual
enum
(albeit necessarily with uncommon name casing, but it's tucked away indefaults::enums
)Also, the DSL is built so you get compiler warnings if you define variabels that you do not use: