Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy diagnostics #840

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Fix clippy diagnostics #840

merged 2 commits into from
Apr 8, 2024

Conversation

squell
Copy link
Member

@squell squell commented Apr 8, 2024

This is best reviewed commit by commit: first commit handles cargo clippy warnings, the second fixes cargo clippy --test warning.

In the first commit, some of the clippy ignores are unavoidable; in the second, it's test code so we don't really care about the "large Error case" warning.

There were also some correct nitpicks by clippy (the ommission of truncate and the location of the the make_zeroed_sigaction function)

@squell squell added minor minor issue, PR without an issue CI Meta-issues related to CI labels Apr 8, 2024
@squell squell enabled auto-merge April 8, 2024 14:43
@squell squell added this pull request to the merge queue Apr 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2024
@squell squell added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit cd8644d Apr 8, 2024
13 checks passed
@squell squell deleted the fix-clippy branch August 9, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Meta-issues related to CI minor minor issue, PR without an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants