Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is best reviewed commit by commit: first commit handles
cargo clippy
warnings, the second fixescargo clippy --test
warning.In the first commit, some of the clippy ignores are unavoidable; in the second, it's test code so we don't really care about the "large Error case" warning.
There were also some correct nitpicks by clippy (the ommission of
truncate
and the location of the themake_zeroed_sigaction
function)