Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues#769 : Add newtypes for UserId, GroupId and ProcessId #812

Closed

Conversation

ZhangHanDong
Copy link
Contributor

fixed #769

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: Patch coverage is 84.23645% with 32 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/system/mod.rs 80.00% 8 Missing ⚠️
src/exec/mod.rs 0.00% 5 Missing ⚠️
src/exec/use_pty/backchannel.rs 0.00% 3 Missing ⚠️
src/exec/use_pty/monitor.rs 0.00% 3 Missing ⚠️
src/system/timestamp.rs 85.71% 3 Missing ⚠️
src/common/error.rs 0.00% 2 Missing ⚠️
src/exec/interface.rs 0.00% 1 Missing ⚠️
src/exec/no_pty.rs 0.00% 1 Missing ⚠️
src/exec/use_pty/parent.rs 0.00% 1 Missing ⚠️
src/su/context.rs 50.00% 1 Missing ⚠️
... and 4 more
Files with missing lines Coverage Δ
src/common/command.rs 91.66% <100.00%> (ø)
src/common/context.rs 89.79% <100.00%> (ø)
src/sudo/env/tests.rs 99.10% <100.00%> (ø)
src/sudo/mod.rs 0.00% <ø> (ø)
src/sudoers/mod.rs 73.02% <100.00%> (ø)
src/sudoers/test/mod.rs 98.20% <100.00%> (+<0.01%) ⬆️
src/system/interface.rs 97.36% <100.00%> (+3.33%) ⬆️
src/system/term/mod.rs 64.92% <100.00%> (-0.23%) ⬇️
src/system/wait.rs 86.86% <100.00%> (-0.64%) ⬇️
src/exec/interface.rs 0.00% <0.00%> (ø)
... and 13 more

... and 13 files with indirect coverage changes

@ZhangHanDong ZhangHanDong marked this pull request as draft December 30, 2023 05:26
@squell
Copy link
Member

squell commented Jan 8, 2024

Can you rebase this on the current main? And also, would you like some assistance with the compliance test failure?

@squell
Copy link
Member

squell commented Oct 22, 2024

Superseded by #879; the issue this PR attempts to fix is now already closed. Thanks for you efforts, however!

@squell squell closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add newtypes for UserId, GroupId and ProcessId
2 participants