Fix visudo bugs; update the CI #2359

error: this expression always evaluates to false --> src/sudo/env/environment.rs:136:13 | 136 | if !PATH_ZONEINFO.is_empty() { | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_is_empty = note: `-D clippy::const-is-empty` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::const_is_empty)]`

multiple fields are never read: src/sudo/cli/mod.rs#L210

error: multiple fields are never read --> src/sudo/cli/mod.rs:210:9 | 208 | pub struct SudoEditOptions { | --------------- fields in this struct 209 | // -k 210 | pub reset_timestamp: bool, | ^^^^^^^^^^^^^^^ 211 | // -n 212 | pub non_interactive: bool, | ^^^^^^^^^^^^^^^ 213 | // -S 214 | pub stdin: bool, | ^^^^^ 215 | // -D 216 | pub chdir: Option<SudoPath>, | ^^^^^ 217 | // -g 218 | pub group: Option<SudoString>, | ^^^^^ 219 | // -u 220 | pub user: Option<SudoString>, | ^^^^ 221 | pub positional_args: Vec<String>, | ^^^^^^^^^^^^^^^

field `0` is never read: src/sudo/cli/mod.rs#L14

error: field `0` is never read --> src/sudo/cli/mod.rs:14:10 | 14 | Edit(SudoEditOptions), | ---- ^^^^^^^^^^^^^^^ | | | field in this variant | help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 14 | Edit(()), | ~~

field `time` is never read: src/system/timestamp.rs#L325

error: field `time` is never read --> src/system/timestamp.rs:325:15 | 325 | Created { time: SystemTime }, | ------- ^^^^ | | | field in this variant

fields `old_time` and `new_time` are never read: src/system/timestamp.rs#L321

error: fields `old_time` and `new_time` are never read --> src/system/timestamp.rs:321:9 | 320 | Updated { | ------- fields in this variant 321 | old_time: SystemTime, | ^^^^^^^^ 322 | new_time: SystemTime, | ^^^^^^^^

fields `group_id` and `name` are never read: src/system/mod.rs#L517

error: fields `group_id` and `name` are never read --> src/system/mod.rs:517:9 | 514 | pub struct Process { | ------- fields in this struct ... 517 | pub group_id: ProcessId, | ^^^^^^^^ 518 | pub session_id: ProcessId, 519 | pub name: PathBuf, | ^^^^ | = note: `Process` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

fields `passwd` and `members` are never read: src/system/mod.rs#L423

error: fields `passwd` and `members` are never read --> src/system/mod.rs:423:9 | 420 | pub struct Group { | ----- fields in this struct ... 423 | pub passwd: String, | ^^^^^^ 424 | pub members: Vec<String>, | ^^^^^^^ | = note: `Group` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]`

clippy

Clippy had exited with the 101 exit code

compliance-tests-og

Process completed with exit code 101.

format

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

format

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

format

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

format

compliance-tests-lint

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

compliance-tests-lint

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

compliance-tests-lint

clippy

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

clippy

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

clippy

build-and-test-msrv

build-and-test-minimal

Cache save failed.

build-and-test-minimal

build-and-test-minimal: src/system/mod.rs#L423

fields `passwd` and `members` are never read

build-and-test-minimal: src/system/mod.rs#L517

fields `group_id` and `name` are never read

build-and-test-minimal: src/system/timestamp.rs#L321

fields `old_time` and `new_time` are never read

build-and-test-minimal: src/system/timestamp.rs#L325

field `time` is never read

build-and-test-minimal: src/sudo/cli/mod.rs#L14

field `0` is never read

build-and-test-minimal: src/sudo/cli/mod.rs#L210

multiple fields are never read

build-and-test-minimal: src/defaults/settings_dsl.rs#L3

non-local `impl` definition, `impl` blocks should be written at the same level as their item

build-and-test-minimal: src/defaults/settings_dsl.rs#L11

non-local `impl` definition, `impl` blocks should be written at the same level as their item

build-and-test-minimal: src/defaults/settings_dsl.rs#L20

non-local `impl` definition, `impl` blocks should be written at the same level as their item

build-and-test-minimal: src/defaults/settings_dsl.rs#L3

non-local `impl` definition, `impl` blocks should be written at the same level as their item

build-and-test-minimal: src/system/mod.rs#L423

fields `passwd` and `members` are never read

build-and-test-minimal: src/system/mod.rs#L517

fields `group_id` and `name` are never read

build-and-test-minimal: src/system/timestamp.rs#L321

fields `old_time` and `new_time` are never read

build-and-test-minimal: src/system/timestamp.rs#L325

field `time` is never read

build-and-test-minimal: src/sudo/cli/mod.rs#L14

field `0` is never read

build-and-test-minimal: src/sudo/cli/mod.rs#L210

multiple fields are never read

build-and-test-minimal: src/defaults/settings_dsl.rs#L3

non-local `impl` definition, `impl` blocks should be written at the same level as their item

build-and-test-minimal: src/defaults/settings_dsl.rs#L11

non-local `impl` definition, `impl` blocks should be written at the same level as their item

build-and-test-minimal: src/defaults/settings_dsl.rs#L20

non-local `impl` definition, `impl` blocks should be written at the same level as their item

build-and-test-minimal: src/defaults/settings_dsl.rs#L3

non-local `impl` definition, `impl` blocks should be written at the same level as their item

e2e-tests

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions/cache@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

e2e-tests

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

e2e-tests

build-and-test

Cache save failed.

build-and-test

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, codecov/codecov-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

build-and-test