[WIP] Adding support for linetools line lists as default #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using the
linetools
package to populate our line lists used when generating spectral features. Up until now, trident has used a text file,lines.txt
with information ~200 different lines including their rest wavelength, oscillator strength, and gamma values.lines.txt
was created using data from the NIST database and follows lines that are largely in the COS low-z window.linetools
is a package created and used by observers across all of UV and optical astronomy assembled from empirical data. While we will leave in the old interface for creating text files, likelines.txt
, for users to populate their own line data, it's generally a better default to uselinetools
for line information since that is what observers are using to analyze these datasets.Right now, this PR is a work in progress, so please do not merge it until I remove the [WIP] tag. I want to put out a new stable version of trident before merging the linetools stuff, and I need to vet it a bit better and add some documentation.
To change Trident's line list to use
linetools
, you simply have to create yourSpectrumGenerator
with a different kwarg:as opposed to if you want the default
lines.txt
line list: