Merge pull request #120 from trickest/fix/standardize-exit-codes

Standardize the exit codes of API errors and the files/library sub-commands

client/request/request.go

@@ -150,7 +150,7 @@ func (r *Request) newRequest(url string) (*http.Request, error) {
 func ProcessUnexpectedResponse(resp *Response) {
 	if resp == nil || resp.response == nil {
 		fmt.Println("Response is nil")
-		os.Exit(0)
+		os.Exit(1)
 	}
 
 	//fmt.Println(resp.response.Request.Method + " " + resp.response.Request.URL.Path + " " + strconv.Itoa(resp.response.StatusCode))
@@ -160,26 +160,26 @@ func ProcessUnexpectedResponse(resp *Response) {
 
 	if resp.response.StatusCode >= http.StatusInternalServerError {
 		fmt.Println("Sorry, something went wrong!")
-		os.Exit(0)
+		os.Exit(1)
 	}
 
 	if resp.response.StatusCode == http.StatusUnauthorized {
 		fmt.Println("Error: Unauthorized to perform this action.\nPlease, make sure that your token is correct and that you have access to this resource.")
-		os.Exit(0)
+		os.Exit(1)
 	}
 
 	var response map[string]interface{}
 	err := json.Unmarshal(resp.body, &response)
 	if err != nil {
 		fmt.Println("Sorry, something went wrong!")
-		os.Exit(0)
+		os.Exit(1)
 	}
 
 	if details, exists := response["details"]; exists {
 		fmt.Println(details)
-		os.Exit(0)
+		os.Exit(1)
 	} else {
 		fmt.Println("Sorry, something went wrong!")
-		os.Exit(0)
+		os.Exit(1)
 	}
 }

cmd/files/filesCreate.go

@@ -27,6 +27,7 @@ var filesCreateCmd = &cobra.Command{
 			err := createFile(filePath)
 			if err != nil {
 				fmt.Printf("Error: %s\n", err)
+				os.Exit(1)
 			} else {
 				fmt.Printf("Uploaded %s successfully\n", filePath)
 			}

cmd/files/filesDelete.go

@@ -3,6 +3,7 @@ package files
 import (
 	"fmt"
 	"net/http"
+	"os"
 	"strings"
 
 	"github.com/spf13/cobra"
@@ -20,6 +21,7 @@ var filesDeleteCmd = &cobra.Command{
 			err := deleteFile(fileName)
 			if err != nil {
 				fmt.Printf("Error: %s\n", err)
+				os.Exit(1)
 			} else {
 				fmt.Printf("Deleted %s successfully\n", fileName)
 			}

cmd/files/filesGet.go

@@ -4,6 +4,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"net/http"
+	"os"
 	"strings"
 
 	"github.com/spf13/cobra"
@@ -27,6 +28,7 @@ var filesGetCmd = &cobra.Command{
 			err := getFile(fileName, outputDir, partialNameMatch)
 			if err != nil {
 				fmt.Printf("Error: %s\n", err)
+				os.Exit(1)
 			} else {
 				fmt.Printf("Retrieved matches for %s successfully\n", fileName)
 			}

cmd/files/filesList.go

@@ -3,6 +3,7 @@ package files
 import (
 	"encoding/json"
 	"fmt"
+	"os"
 
 	"github.com/spf13/cobra"
 	"github.com/trickest/trickest-cli/types"
@@ -23,6 +24,7 @@ var filesListCmd = &cobra.Command{
 		files, err := getMetadata(searchQuery)
 		if err != nil {
 			fmt.Printf("Error: %s\n", err)
+			os.Exit(1)
 		} else {
 			printFiles(files, jsonOutput)
 		}

cmd/library/libraryListModules.go

@@ -4,6 +4,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"math"
+	"os"
 
 	"github.com/spf13/cobra"
 	"github.com/trickest/trickest-cli/cmd/list"
@@ -21,7 +22,8 @@ var libraryListModulesCmd = &cobra.Command{
 		if len(modules) > 0 {
 			printModules(modules, jsonOutput)
 		} else {
-			fmt.Println("Couldn't find any workflow in the library!")
+			fmt.Println("Couldn't find any module in the library!")
+			os.Exit(1)
 		}
 	},
 }

cmd/library/libraryListTools.go

@@ -3,6 +3,7 @@ package library
 import (
 	"fmt"
 	"math"
+	"os"
 
 	"github.com/spf13/cobra"
 	"github.com/trickest/trickest-cli/cmd/list"
@@ -19,6 +20,7 @@ var libraryListToolsCmd = &cobra.Command{
 			PrintTools(tools, jsonOutput)
 		} else {
 			fmt.Println("Couldn't find any tool in the library!")
+			os.Exit(1)
 		}
 	},
 }

cmd/library/libraryListWorkflows.go

@@ -3,6 +3,7 @@ package library
 import (
 	"encoding/json"
 	"fmt"
+	"os"
 
 	"github.com/google/uuid"
 	"github.com/spf13/cobra"
@@ -22,6 +23,7 @@ var libraryListWorkflowsCmd = &cobra.Command{
 			printWorkflows(workflows, jsonOutput)
 		} else {
 			fmt.Println("Couldn't find any workflow in the library!")
+			os.Exit(1)
 		}
 	},
 }