Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility and keyboard navigation issues #35

Closed
wants to merge 1 commit into from

Conversation

mackenly
Copy link
Member

Accessibility and keyboard navigation fixes

Closes #34

@mackenly mackenly linked an issue Oct 11, 2022 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Oct 11, 2022

Deploy Preview for tricitiesdev ready!

Name Link
🔨 Latest commit 55d175a
🔍 Latest deploy log https://app.netlify.com/sites/tricitiesdev/deploys/6345a12b922bf4000a6df6a7
😎 Deploy Preview https://deploy-preview-35--tricitiesdev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@RyannosaurusRex RyannosaurusRex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good!

@RyannosaurusRex
Copy link
Member

Are you using aXe for scanning for these or something else?

@mackenly
Copy link
Member Author

@RyannosaurusRex No, just chrome dev tools. I'll check that out though.

@RyannosaurusRex
Copy link
Member

@mackenly Hey, this is still in Draft it looks like. Just wanted to follow up on it and make sure it wasn't actually ready you were waiting on me. 😅

@mackenly
Copy link
Member Author

@mackenly Hey, this is still in Draft it looks like. Just wanted to follow up on it and make sure it wasn't actually ready you were waiting on me. 😅

Ah, oops. I think it's okay as is but more improvements could be made.

@mackenly
Copy link
Member Author

Closing since v2 will completely redesign

@mackenly mackenly closed this Oct 12, 2023
@mackenly mackenly deleted the feature/a11y-fixes branch October 12, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility and keyboard navigation issues
2 participants