-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T3T1 support, space saving, GH actions emulators #234
Conversation
8ab813d
to
0d6d9a2
Compare
It is not yet available dynamically from Gitlab CI --- the pipeline needs to succeed
In the end, getting the latest core emulators from @vdovhanych I am already satisfied with this, can you please approve the small Dockerfile changes? It is just setting up I did quite a lot of experiments with decreasing the image size, with the idea of deleting as much nix-connected stuff as possible.
There are two upcoming tasks/TODOs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do not use the download option from GitHub then its fine like this, but read my comment for that.
@grdddj As I said I don't see that much benefits from using Nix inside of Docker image so I vote for removing it. |
Im already working on simple alpine image without nix, should be third the size |
@vdovhanych Nice thanks! Every saved MB here = saved few minutes of runtime in total across all our CI jobs |
Support for T3T1 emulators
Decreasing the size of Docker image
Getting latest/main emulators from GH-actions
TODO: remove the temporary commit and load
GH_TOKEN
from env