Chore/update dependencies #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonlesisz
added
the
READY FOR REVIEW
szymonlesisz
requested review from
keraf,
mroz22,
robertbrada and
slowbackspace
as code owners
szymonlesisz
removed
the
READY FOR REVIEW
szymonlesisz
commented
Nov 23, 2020
packages/suite/.stylelintignore
Outdated
| @@ -0,0 +1,6 @@ | |||
| # stylelint does not accept re-exporting types (export type {} from ...). throws Unexpected token | |||
There was a problem hiding this comment.
controversial,
stylelint doesnt parse export type { A } from 'b' correctly and throws Unexpected token error. i didn't find any solution and i don't want to waste my time with it.
szymonlesisz
commented
Nov 23, 2020
szymonlesisz
added
the
READY FOR REVIEW
szymonlesisz
force-pushed
the
chore/update-dependencies
branch
from
45a49e7 to
33fcc3c
Compare
slowbackspace
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turns out there was inconsistency with
stylelint.@trezor/suiteand@trezor/componentsuses different versions (in suite was way outdated), multiple eslint/stylelint errors shows up after the update