feat(suite-native): Send Custom Fee #15364
Conversation
PeKne
requested review from
Nodonisko,
jvaclavik,
adamhavel and
a team
as code owners
|
🚀 Expo preview is ready!
|
PeKne
force-pushed
the
feat/native/custom-fee
branch
from
1e87211
to
98eb80e
Compare
PeKne
force-pushed
the
feat/native/custom-fee
branch
from
98eb80e
to
2174dd8
Compare
| onClose(); | ||
| }); | ||
|
|
||
| const animatedButtonContainerStyle = useAnimatedStyle( |
There was a problem hiding this comment.
I think you might want to use this https://docs.swmansion.com/react-native-reanimated/docs/layout-animations/layout-transitions#linear-transition
It should work better and it should also add some nice animation when that error box is diplayed
There was a problem hiding this comment.
The layout linear transition works good for calculating animation of the component wrappen in the Animated.View. But I decided to use this kind of height transformation, because it also nicely resizes the whole bottomSheet (wrapper of the content) without doing any nasty layout jumps. If you have some better solution to address this issue, I will be happy to fix that.
| </HStack> | ||
| </VStack> | ||
| <HStack flex={1} justifyContent="space-between"> | ||
| <Box flex={1 / 3}> |
There was a problem hiding this comment.
I think if you use just 1 and later 2 it will work same from what I know about flexbox
| const mockedFee = transactionBytes * Number(feePerUnit); | ||
| const mockedTotalAmount = mockedFee + (Number(normalFee.totalSpent) - Number(normalFee.fee)); | ||
| const isSubmittable = selectedFeeLevelTransaction.type === 'final'; | ||
| const mockedFee = BigNumber(transactionBytes) |
There was a problem hiding this comment.
Can we memo these BigNumber operations? They are usually quite slow
|
|
||
| // TODO: estimate do not work for error state EtH | ||
| // If the trezor-connect is unable to compose the transaction, we display rough estimate of the fee instead. | ||
| const feeEstimate = watchedFeePerUnit |
|
|
||
| if (!networkFeeInfo) return false; | ||
|
|
||
| const feeBig = new BigNumber(value); |
There was a problem hiding this comment.
It is necessary to have BN here? How does numbers looks like?
I guess this validation runs with every change of form so it should be super quick.
There was a problem hiding this comment.
you are right, no need for BN here 61136b9
| state: NativeSendRootState, | ||
| ): GeneralPrecomposedTransaction | undefined => state.wallet.send.feeLevels.custom; | ||
|
|
||
| export const selectFeeLevelTransactionBytes = ( |
There was a problem hiding this comment.
use memoize, especially if you use BN
Description
Related Issue
Resolve #15180
Screenshots:
BTC
Screen.Recording.2024-11-13.at.9.57.12.mov
BTC - Send Max
Screen.Recording.2024-11-13.at.10.40.24.mov
ETH
Screen.Recording.2024-11-13.at.10.39.37.mov