Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doge smart fees #15352

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Doge smart fees #15352

merged 2 commits into from
Nov 12, 2024

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented Nov 12, 2024

this PR makes fee estimation and tx composition using values returned by doge blockbooks. Txs should now have fee high enough to get mined. On the other hand, we might be overpaying slightly now.

@mroz22 mroz22 marked this pull request as ready for review November 12, 2024 11:33
Copy link
Contributor

@szymonlesisz szymonlesisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit :)

@mroz22 mroz22 merged commit b33ad25 into develop Nov 12, 2024
153 of 156 checks passed
@mroz22 mroz22 deleted the doge-smart-fees branch November 12, 2024 12:21
@STew790
Copy link
Contributor

STew790 commented Nov 12, 2024

QA OK
LGTM, transaction is already confirmed.
Here is a tx I sent from develop an hour ago:
https://doge5.trezor.io/tx/e8f4b3ae822afa7f6e75241cf351c98028a4e51084dffdca18b6e6c2a696208f
and here is the tx from this branch which is already confirmed:
https://doge5.trezor.io/tx/29ee01c7795f933c01688303952b809503f0f3a30d3b867d5aeaa946d7622054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants