feat(mobile): minor perf stuff #14264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vytick
reviewed
Sep 10, 2024
| // cache up to 3 devices to make sure it works correctly | ||
| { size: 3 }, | ||
| ); | ||
| export const selectAccountsByDeviceState = ( |
There was a problem hiding this comment.
Maybe it is missing memoization, but it feels that switching between home, assets and receive tab takes really long time. In my ios simulator it took around 5 seconds on fully discovered allseed.
There was a problem hiding this comment.
Hmm. Now i tried the same on different branch and it also took a long time 🤔. So maybe not related to this change, but still feels very slow.
There was a problem hiding this comment.
Good to know I will check what's happening.
There was a problem hiding this comment.
I think it's because there is quite a lot of accounts on all seed and there is no FlashList for Accounts/Receive screen.
There was a problem hiding this comment.
not related to any of my changes
matejkriz
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improved performance during discovery for about ~10 FPS on iPhone. Android not measured but could be even better.
Surprisingly main issues was that memoized selector (I start to really dislike proxy-memoize because of too much magic and unpredictable performance)
Related Issue
Resolve
Screenshots: