Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite-native): after coin enabling is enabled, show relevant normal accounts #14228

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

vytick
Copy link
Contributor

@vytick vytick commented Sep 9, 2024

When checking for discovery updates, make sure that first normal account is visible for enabled networks when coin enabling is active.

This might be needed in case user has View only device from before coin enabling was active in such case the first normal account can be invisible. We need to make it visible.

Related Issue

Resolve #14225

@vytick vytick added the mobile Suite Lite issues and PRs label Sep 9, 2024
@vytick vytick requested a review from a team as a code owner September 9, 2024 16:04
Copy link
Member

@matejkriz matejkriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered migration instead? It can happen only once and only for those that had some view only devices on older version.

@matejkriz
Copy link
Member

For a reference, the migration is not used because it has to happen when device is connected, not on app start.

@vytick
Copy link
Contributor Author

vytick commented Sep 10, 2024

/rebase

Copy link

@trezor-ci trezor-ci force-pushed the fix/native/coin-enabling-update branch from 5e9aa79 to b447d65 Compare September 10, 2024 15:10
@vytick vytick merged commit 45547b2 into develop Sep 10, 2024
18 of 24 checks passed
@vytick vytick deleted the fix/native/coin-enabling-update branch September 10, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View only wallet with no accounts not showing empty accounts after turning ON Coin enabling
2 participants