Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/release 24 5 intermediary #12767

Closed
wants to merge 3 commits into from

Conversation

matejkriz
Copy link
Member

Description

  • SatoshiLabs, s.r.o. renamed to Trezor Company s.r.o. so there is a change in publisher name of Win signing certificate and we need a version of Suite signed by old certificate but accepting new certificate during auto-update.
  • Because of new publisher name in Win signing certificate, we have to switch to a new auto-update provider so users on older Suite versions get always this version at first and then they can update on latest Suite signed by new certificate.
  • Signature file is downloaded from the same URL as installation file (which is fine, public key is bundled inside Suite)
  • EAP version is distributed in different bucket/folder
  • Changelog has to be bundled with installation files, no longer downloads from GitHub.

- SatoshiLabs, s.r.o. renamed to Trezor Company s.r.o. so there is a change in publisher name of Win signing certificate and we need a version of Suite signed by old certificate but accepting new certificate during auto-update.
- Because of new publisher name in Win signing certificate, we have to switch to a new auto-update provider so users on older Suite versions get always this version at first and then they can update on latest Suite signed by new certificate.
- Signature file is downloaded from the same URL as installation file (which is fine, public key is bundled inside Suite)
- EAP version is distributed in different bucket/folder
- Changelog has to be bundled with installation files, no longer downloads from GitHub.
…atically

- release-notes.md file is copied automatically during build and used by electron-builder to generate changelog in all latest*.yml files
- platform specific changelog can be specifed in files release-notes-mac.md release-notes-linux.md or release-notes-windows.md files.
@matejkriz matejkriz marked this pull request as ready for review June 7, 2024 10:46
@matejkriz matejkriz requested a review from komret as a code owner June 7, 2024 10:46
@matejkriz
Copy link
Member Author

The lint issue can be ignored here, it's totally unrelated to the changes and fixed in develop.

@matejkriz
Copy link
Member Author

closing the PR in favour of #12788, keeping branch as it is based on release/24.5

@matejkriz matejkriz closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant