feat(suite-native): Simplify biometrics UI logic #11910
Conversation
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
|
|
||
| extend: { | ||
| condition: showShadow, | ||
| style: { |
There was a problem hiding this comment.
micro nitpick:
| style: { | |
| style: utils.boxShadow.small |
|
Didn't you upload the iOS demo screenshot twice? The Android and iOS screenshots look identical. But the code changes are quite understandable, so not a big deal :). |
|
They are slightly different :) The icons look similar, but are not the same |
Ok, you are right. The Apple dynamic island confused me :D |
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/8599526674 |
trezor-ci
force-pushed
the
feat/native-biometrics-ui-simplification
branch
from
0da1bf0
to
957593e
Compare
|
@SocketSecurity ignore-all |
Change the UI according to 🆕 design and this
✅ Use the same icon/text for all possible options.
✅ Differentiate ios and android according to design.
✅ Change the order of primary/secondary button so the primary is on top
✅ Change icon in settings to follow other changes
Resolve #11511
Screenshots:
ios:
android:
