chore(suite): add @typescript-eslint/strict-boolean-expressions rule as warning

.eslintrc.js

@@ -10,6 +10,8 @@ module.exports = {
         ecmaFeatures: {
             jsx: true,
         },
+        project: ['./tsconfig.json'],
+        tsconfigRootDir: __dirname,
     },
     plugins: [
         'import',
@@ -56,10 +58,24 @@ module.exports = {
         'packages/connect-examples',
         'ci/',
         'eslint-local-rules/*',
+        '*.config.js',
+        '.eslintrc.js',
+        '.eslintrc.cjs',
     ],
     rules: {
+<<<<<<< HEAD
         '@typescript-eslint/no-empty-object-type': 'off',
         '@typescript-eslint/no-require-imports': 'off',
+=======
+        '@typescript-eslint/strict-boolean-expressions': [
+            'warn',
+            {
+                allowString: false,
+                allowNumber: false,
+                allowNullableObject: false,
+            },
+        ],
+>>>>>>> 05cf6923bf (chore(suite): add @typescript-eslint/strict-boolean-expressions rule as warning)
         '@typescript-eslint/prefer-ts-expect-error': 'error',
         // I believe type is enforced by callers.
         '@typescript-eslint/explicit-function-return-type': 'off',
@@ -224,10 +240,10 @@ module.exports = {
         // These rules have to do with variable declarations.
         'no-label-var': 'error', // disallow labels that share a name with a variable
         'no-shadow': 'off', // @typescript-eslint/no-shadow will be used instead
-        '@typescript-eslint/no-shadow': [
-            'error',
-            { builtinGlobals: true, allow: ['_', 'error', 'resolve', 'reject', 'fetch'] },
-        ], // disallow declaration of variables already declared in the outer scope
+        // '@typescript-eslint/no-shadow': [
+        //     'error',
+        //     { builtinGlobals: true, allow: ['_', 'error', 'resolve', 'reject', 'fetch'] },
+        // ], // disallow declaration of variables already declared in the outer scope
         'no-shadow-restricted-names': 'error', // disallow shadowing of names such as arguments
         'no-undefined': 'off', // disallow use of undefined variable (off by default)
         'no-undef-init': 'error', // disallow use of undefined when initializing variables

packages/analytics/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/auth-server/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/blockchain-link-types/.eslintrc.js

@@ -0,0 +1,8 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+    rules: {
+        'import/no-extraneous-dependencies': ['error', { includeTypes: true }],
+    },
+};

packages/blockchain-link-types/tsconfig.json

@@ -1,8 +1,15 @@
 {
     "extends": "../../tsconfig.base.json",
-    "compilerOptions": { "outDir": "libDev" },
+    "compilerOptions": {
+        "outDir": "libDev"
+    },
+    "include": ["src"],
     "references": [
-        { "path": "../type-utils" },
-        { "path": "../utxo-lib" }
+        {
+            "path": "../type-utils"
+        },
+        {
+            "path": "../utxo-lib"
+        }
     ]
 }

packages/blockchain-link-utils/.eslintrc.js

@@ -1,4 +1,7 @@
 module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
     rules: {
         'import/no-extraneous-dependencies': ['error', { includeTypes: true }],
     },

packages/blockchain-link/.eslintrc.js

@@ -1,7 +1,11 @@
 module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
     rules: {
         camelcase: 'off',
         'no-underscore-dangle': 'off',
         'no-console': 'warn',
     },
+    ignorePatterns: ['jest.config.*.js'],
 };

packages/coinjoin/.eslintrc.js

@@ -3,4 +3,7 @@ module.exports = {
         'no-bitwise': 'off',
         'no-console': 'warn',
     },
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
 };

packages/components/.eslintrc.js

@@ -0,0 +1,8 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+    rules: {
+        'import/no-extraneous-dependencies': ['error', { includeTypes: true }],
+    },
+};

packages/connect-analytics/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/connect-common/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/connect-explorer-webextension/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/connect-explorer/.eslintrc.js

@@ -15,4 +15,7 @@ module.exports = {
         ],
     },
     extends: ['plugin:mdx/recommended'],
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
 };

packages/connect-iframe/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/connect-plugin-ethereum/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/connect-plugin-stellar/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/connect-popup/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/connect-popup/e2e/tests/webextension-example.test.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line @typescript-eslint/no-shadow
 import { test, expect, chromium } from '@playwright/test';
 import path from 'path';
 

packages/connect-ui/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/connect-web/.eslintrc.js

@@ -3,4 +3,7 @@ module.exports = {
         'no-underscore-dangle': 'off', // underscore is used
         camelcase: 'off', // camelcase is used
     },
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
 };

packages/connect-webextension/.eslintrc.js

@@ -2,4 +2,7 @@ module.exports = {
     rules: {
         'no-underscore-dangle': 'off', // underscore is used
     },
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
 };

packages/connect/.eslintrc.js

@@ -1,4 +1,7 @@
 module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
     rules: {
         'no-bitwise': 'off', // airbnb-base: used in hardending
         'no-underscore-dangle': 'off', // underscore is used

packages/crypto-utils/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/device-utils/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/dom-utils/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/e2e-utils/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/env-utils/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/ipc-proxy/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/node-utils/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/protobuf/.eslintrc.js

@@ -1,6 +1,10 @@
 module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
     rules: {
         '@typescript-eslint/ban-types': 'off', // allow {} in protobuf.d.ts
         '@typescript-eslint/no-shadow': 'off',
     },
+    ignorePatterns: ['**/scripts/*'],
 };

packages/protobuf/tsconfig.json

@@ -1,6 +1,12 @@
 {
     "extends": "../../tsconfig.base.json",
-    "compilerOptions": { "outDir": "libDev" },
-    "include": ["src"],
-    "references": [{ "path": "../schema-utils" }]
+    "compilerOptions": {
+        "outDir": "libDev"
+    },
+    "include": ["src", "tests"],
+    "references": [
+        {
+            "path": "../schema-utils"
+        }
+    ]
 }

packages/protocol/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/react-native-usb/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/react-native-usb/plugins/withUSBDevice.js

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-shadow */
 /* eslint-disable require-await */
 const { AndroidConfig, withAndroidManifest } = require('expo/config-plugins');
 

packages/react-utils/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/request-manager/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/schema-utils/.eslintrc.js

@@ -1,4 +1,7 @@
 module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
     rules: {
         'no-console': 'warn',
         'import/no-extraneous-dependencies': ['error', { devDependencies: true }],

packages/styles/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/suite-analytics/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/suite-analytics/src/constants.ts

@@ -5,7 +5,6 @@ export enum AppUpdateEventStatus {
     InstallAndRestart = 'install-and-restart',
     InstallOnQuit = 'install-on-quit',
     Closed = 'closed',
-    // eslint-disable-next-line @typescript-eslint/no-shadow
     Error = 'error',
 }
 

packages/suite-build/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/suite-data/.eslintrc.js

@@ -0,0 +1,6 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+    ignorePatterns: ['browser-detection.webpack.ts'],
+};

packages/suite-desktop-api/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/suite-desktop-core/.eslintrc.js

@@ -0,0 +1,6 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+    ignorePatterns: ['core.webpack.config.ts', 'scripts'],
+};

packages/suite-desktop-ui/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/suite-desktop/.eslintrc.js

@@ -0,0 +1,6 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+    ignorePatterns: ['electron-builder-config.js'],
+};

packages/suite-desktop/src/index.ts

@@ -0,0 +1 @@
+// just here to force ESLint to not complain about not checking anything

packages/suite-storage/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/suite-web/.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
+};

packages/suite/.eslintrc.js

@@ -2,4 +2,7 @@ module.exports = {
     rules: {
         'react/style-prop-object': ['error', { allow: ['FormattedNumber'] }],
     },
+    parserOptions: {
+        tsconfigRootDir: __dirname,
+    },
 };