Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Biometric icons and texts #11511

Closed
4 tasks done
vytick opened this issue Mar 8, 2024 · 3 comments · Fixed by #11910
Closed
4 tasks done

Change Biometric icons and texts #11511

vytick opened this issue Mar 8, 2024 · 3 comments · Fixed by #11910
Assignees
@vytick @shenkys
Labels
low hanging fruit Simple, quick task. Doable in 2 hours. mobile Suite Lite issues and PRs

Comments

@vytick
Copy link
Contributor

vytick commented Mar 8, 2024 •
edited
Loading

Change the UI according to 🆕 design and this

  • Use the same icon/text for all possible options.
  • Differentiate ios and android according to design.
  • Change the order of primary/secondary button so the primary is on top
  • Change icon in settings to follow other changes
@vytick vytick converted this from a draft issue Mar 8, 2024
@vytick vytick removed this from Issues Suite Mar 8, 2024
@vytick vytick added the mobile Suite Lite issues and PRs label Mar 8, 2024
@shenkys
Copy link

shenkys commented Mar 12, 2024

Design here

Please also change the order of primary/secondary button so the primary is on top. THX

@shenkys shenkys moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile Mar 12, 2024
@shenkys
Copy link

shenkys commented Mar 12, 2024

Locked screen design here

Only difference between AN & iOS is the icon (for AN we use AN fingerprint icon, for iOS it's an iOS icon - you can see it in the board)

@shenkys shenkys moved this from 🏃‍♀️ In progress to 🎯 To do in Suite Mobile Mar 12, 2024
@sime sime added the low hanging fruit Simple, quick task. Doable in 2 hours. label Mar 14, 2024
@vytick vytick changed the title Biometric might show wrong icons Change Biometric icons and texts Apr 3, 2024
@vytick vytick moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile Apr 5, 2024
@vytick vytick mentioned this issue Apr 5, 2024
Merged
@vytick vytick moved this from 🏃‍♀️ In progress to 🔎 Needs review in Suite Mobile Apr 5, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Suite Mobile Apr 8, 2024
@bosomt
Copy link
Contributor

bosomt commented Apr 18, 2024

QA OK

  • version 24.4.0 c8e7d2e
  • Android 14 , Nothing phone 1

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Mobile Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vytick vytick

@shenkys shenkys

Labels
low hanging fruit Simple, quick task. Doable in 2 hours. mobile Suite Lite issues and PRs
Projects
Suite Mobile
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(suite-native): Simplify biometrics UI logic trezor/trezor-suite
4 participants
@sime @vytick @bosomt @shenkys