Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: less verbose S3 upload #4342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: less verbose S3 upload #4342

wants to merge 1 commit into from

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Nov 12, 2024

No significant speedup observed, the longest (T2B1) ui-report action takes 6m30s (previously around 8m?). May still be worth it for not filling the log with useless info.

Copy link

github-actions bot commented Nov 12, 2024

legacy UI changes device test(screens) main(screens)

Copy link

github-actions bot commented Nov 12, 2024

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@@ -38,12 +38,12 @@ runs:
shell: sh
- name: Upload report
run: |
aws s3 sync --no-progress ${{ github.run_id }} s3://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}
aws s3 sync --no-progress --quiet ${{ github.run_id }} s3://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--only-show-errors is probably better

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, missed this one, thanks

@mmilata mmilata marked this pull request as ready for review November 12, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 Needs review
Development

Successfully merging this pull request may close these issues.

3 participants