-
-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Add coin definition for eCash XEC (altcoin based on bitcoin) #4336
base: main
Are you sure you want to change the base?
Conversation
@matejcik Can you explain why the CI is failing and if there is something I need to do to fix it ? It looks like a permission issue at first sight but not sure |
"add to github project" -> don't worry about this one "gen check" -> you did not run |
|
I pushed 2 new commits:
I ran Should I squash the commits ? |
common/defs/bitcoin/ecash.json
Outdated
@@ -0,0 +1,44 @@ | |||
{ | |||
"coin_name": "eCash", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep the name like this.
That way we do not need to change 2 regex-es, only one.
"coin_name": "eCash", | |
"coin_name": "Ecash", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep the name like this.
That way we do not need to change 2 regex-es, only one.
Good call, since it's not used for display it's fine to keep the uppercase here. I updated and pushed accordingly.
147b536
to
aab3c91
Compare
the support info is wrong. |
The regex enforces starting with an uppercase letter, which doesn't work for eCash and for xRhodium. An exception is added to handle this naming, as well as a comment to remind why the regex contains this special case. This fixes `make defs_check` for eCash.
aab3c91
to
00cec18
Compare
@matejcik Thanks I updated accordingly. |
This PR adds the definition for eCash (XEC).
I tried to use support.py to generate the support.json but this currenly fails due to the missing release file for T3W1 so I updated manually.
make gen
builds successfully. I also ranmake style_check
but this failed on me with 122reportArgumentType
errors frompyright
. I'm probably not using the right version, but all the reports are unrelated to this change, and the other linters return no error. I expect it to pass on CI.