Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framebuffer access control #4267

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Framebuffer access control #4267

merged 1 commit into from
Oct 22, 2024

Conversation

cepetr
Copy link
Contributor

@cepetr cepetr commented Oct 16, 2024

This small PR adds precise access control for the framebuffer (and resolves #4207).

This change is primarily aimed at devices using two framebuffers (T3T1) but also affects devices using a single framebuffer (T2B1, T3B1).

Before this change, the unprivileged app had access to both framebuffers at any time. Now, an unprivileged application has access only to the framebuffer acquired by display_get_frame_buffer() until it releases it by calling the display_refresh() function.

@cepetr cepetr added T2B1 Trezor Safe 3 T3T1 T3B1 labels Oct 16, 2024
@cepetr cepetr self-assigned this Oct 16, 2024
@cepetr cepetr force-pushed the cepetr/platform-common-cleanup branch from 91c5ea3 to 8664fcd Compare October 21, 2024 08:15
@cepetr cepetr marked this pull request as ready for review October 21, 2024 08:16
@cepetr cepetr requested a review from prusnak as a code owner October 21, 2024 08:16
@cepetr cepetr force-pushed the cepetr/platform-common-cleanup branch from 09652a4 to 8792ca9 Compare October 21, 2024 14:13
@cepetr cepetr force-pushed the cepetr/fb-access-control branch 2 times, most recently from fb98db2 to 9bb8d97 Compare October 21, 2024 14:16
Copy link

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) 2724
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@Hannsek
Copy link
Contributor

Hannsek commented Oct 21, 2024

What is the diff here? Only the 4 pixels?

@cepetr
Copy link
Contributor Author

cepetr commented Oct 22, 2024

What is the diff here? Only the 4 pixels?

It seems like a recurring issue with the loader. @TychoVrahe, you fixed this a few weeks ago, didn’t you?

@TychoVrahe
Copy link
Contributor

I created this PR to fix that, it hasn't been merged as another solution, via GFL, is preffered.

See also slack discussion: https://satoshilabs.slack.com/archives/C054XGU77QV/p1724926329014489

Lets ignore this here.

@cepetr cepetr force-pushed the cepetr/platform-common-cleanup branch from 7e6e71a to 9cddb02 Compare October 22, 2024 06:35
Base automatically changed from cepetr/platform-common-cleanup to main October 22, 2024 07:06
@cepetr cepetr merged commit 7689132 into main Oct 22, 2024
93 checks passed
@cepetr cepetr deleted the cepetr/fb-access-control branch October 22, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2B1 Trezor Safe 3 T3B1 T3T1
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

Framebuffer accessibility in coreapp
3 participants