-
-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framebuffer access control #4267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cepetr
force-pushed
the
cepetr/fb-access-control
branch
from
October 16, 2024 10:37
60e5892
to
f8861b5
Compare
cepetr
force-pushed
the
cepetr/platform-common-cleanup
branch
from
October 21, 2024 08:15
91c5ea3
to
8664fcd
Compare
cepetr
force-pushed
the
cepetr/fb-access-control
branch
from
October 21, 2024 08:15
f8861b5
to
acf1ab1
Compare
TychoVrahe
reviewed
Oct 21, 2024
TychoVrahe
approved these changes
Oct 21, 2024
cepetr
force-pushed
the
cepetr/platform-common-cleanup
branch
from
October 21, 2024 14:13
09652a4
to
8792ca9
Compare
cepetr
force-pushed
the
cepetr/fb-access-control
branch
2 times, most recently
from
October 21, 2024 14:16
fb98db2
to
9bb8d97
Compare
|
What is the diff here? Only the 4 pixels? |
It seems like a recurring issue with the loader. @TychoVrahe, you fixed this a few weeks ago, didn’t you? |
I created this PR to fix that, it hasn't been merged as another solution, via GFL, is preffered. See also slack discussion: https://satoshilabs.slack.com/archives/C054XGU77QV/p1724926329014489 Lets ignore this here. |
cepetr
force-pushed
the
cepetr/platform-common-cleanup
branch
from
October 22, 2024 06:35
7e6e71a
to
9cddb02
Compare
[no changelog]
cepetr
force-pushed
the
cepetr/fb-access-control
branch
from
October 22, 2024 07:08
9bb8d97
to
f3055c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR adds precise access control for the framebuffer (and resolves #4207).
This change is primarily aimed at devices using two framebuffers (T3T1) but also affects devices using a single framebuffer (T2B1, T3B1).
Before this change, the unprivileged app had access to both framebuffers at any time. Now, an unprivileged application has access only to the framebuffer acquired by
display_get_frame_buffer()
until it releases it by calling thedisplay_refresh()
function.