Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for T3W1 #4250

Merged
merged 8 commits into from
Oct 9, 2024
Merged

add support for T3W1 #4250

merged 8 commits into from
Oct 9, 2024

Conversation

TychoVrahe
Copy link
Contributor

This PR introduces initial support for T3W1, including emulator build.

The HW support is currently targeted to dev board 1, running on F4 MCU. This will only be supported temporarily. To support this HW LHS200kb display panel is added. No BLE support introduced yet.

Some small preparations/adjustments done in separate commits, namely fixing some issues with 16bit display bus, removing unnecessary button syscalls and few more details.

@TychoVrahe TychoVrahe requested a review from cepetr October 7, 2024 13:20
@TychoVrahe TychoVrahe self-assigned this Oct 7, 2024
@TychoVrahe TychoVrahe removed the request for review from prusnak October 7, 2024 13:21
Copy link

github-actions bot commented Oct 7, 2024

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

Copy link
Contributor

@cepetr cepetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

#elif defined(DISPLAY_PANEL_LHS200KB_IF21)
#include "panels/lhs200kb-if21.h"
#define PANEL_INIT_SEQ lhs200kb_if21_init_seq
#define PANEL_ROTATE lhs200kb_if21_rotate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is starting to get a bit confusing. I think we could come up with a different approach to handle the various panels, but I don't think we need to change it just now.

@Hannsek
Copy link
Contributor

Hannsek commented Oct 9, 2024

@matejcik can you merge please? 🙏🏻

@matejcik
Copy link
Contributor

matejcik commented Oct 9, 2024

i squashed and force-pushed, @cepetr please double-check that I did not mess anything up and merge if it's ok

@cepetr cepetr merged commit d71d9e9 into main Oct 9, 2024
85 checks passed
@cepetr cepetr deleted the tychovrahe/T3W1/add branch October 9, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

4 participants