SLIP-39 extend_mnemonics() #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkozlik
added
core
onvej-sl
reviewed
Oct 7, 2024
onvej-sl
approved these changes
Oct 9, 2024
[no changelog]
andrewkozlik
force-pushed
the
andrewkozlik/slip39
branch
from
e94cb39
to
fb60bbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a function which extends a set of SLIP-39 mnemonics by extra shares, while maintaining the threshold.
This, for example, allows extending a 2-of-2 backup to 2-of-3, where the first two shares remain the same. It also allows reconstructing lost shares by providing any threshold number of shares and requesting the original share count.
The implementation is limited to Slip39_Basic, i.e. single group.
Slack thread: https://satoshilabs.slack.com/archives/C016ACNF1BN/p1727975559358469