-
-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark application #4101
Merged
Merged
Benchmark application #4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejcik
requested changes
Sep 30, 2024
matejcik
reviewed
Oct 9, 2024
@@ -280,25 +281,26 @@ build_firmware: templates build_cross ## build firmware with frozen modules | |||
PYOPT="$(PYOPT)" BITCOIN_ONLY="$(BITCOIN_ONLY)" \ | |||
BOOTLOADER_QA="$(BOOTLOADER_QA)" BOOTLOADER_DEVEL="$(BOOTLOADER_DEVEL)" \ | |||
DISABLE_OPTIGA="$(DISABLE_OPTIGA)" THP="$(THP)" NEW_RENDERING="$(NEW_RENDERING)" \ | |||
$(FIRMWARE_BUILD_DIR)/firmware.bin | |||
BENCHMARK="$(BENCHMARK)" $(FIRMWARE_BUILD_DIR)/firmware.bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that there's now a common section oh it's not here yet, it's in #4234. not sure when that will land so you can either go ahead here or wait for itSCONS_OPTS
where this will go when you're rebasing
matejcik
approved these changes
Oct 9, 2024
onvej-sl
force-pushed
the
onvej-sl/benchmark
branch
3 times, most recently
from
October 10, 2024 12:48
2fd91e3
to
db808b3
Compare
[no changelog]
[no changelog]
[no changelog]
onvej-sl
force-pushed
the
onvej-sl/benchmark
branch
from
October 10, 2024 17:31
db808b3
to
35da0e7
Compare
M1nd3r
reviewed
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements an application that benchmarks various cryptographic primitives.
The application is hidden behind a compilation flag:
BENCHMARK=1 make -C core build_firmware
Using
trezorctl
, you can: