New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[draft] THP #4050

Draft

M1nd3r wants to merge 1 commit into main from M1nd3r/thp

+19,712 −7,070

Contributor

M1nd3r commented Jul 22, 2024

No description provided.

M1nd3r requested a review from onvej-sl

July 22, 2024 11:42

github-actions bot commented Jul 22, 2024 •

edited

Loading

core UI changes	device test	click test	persistence test
T2T1 Model T	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
T3B1 Safe 3	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
T3T1 Safe 5	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
All	main(screens)

M1nd3r self-assigned this

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/received_message_handler.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/received_message_handler.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/cpace.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/channel.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/pairing_context.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/channel.py Outdated Show resolved Hide resolved

Contributor

onvej-sl commented Jul 26, 2024

Well done, @M1nd3r !

I reviewed the usage of cryptography and compliance with our documentation of the secure channel layer.

M1nd3r force-pushed the M1nd3r/thp branch from e402934 to 98c4f11 Compare

October 10, 2024 10:44

github-actions bot commented Oct 10, 2024 •

edited

Loading

legacy UI changes	device test(screens) main(screens)

M1nd3r changed the title ~~[draft] Review of cryptography in the new THP~~ [draft] THP

M1nd3r force-pushed the M1nd3r/thp branch 6 times, most recently from 80cee55 to 027570a Compare

November 14, 2024 13:56


          feat: implement new Trezor-Host protocol

3b1fc34

M1nd3r force-pushed the M1nd3r/thp branch from 027570a to 3b1fc34 Compare

November 15, 2024 14:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

onvej-sl onvej-sl left review comments

matejcik Awaiting requested review from matejcik matejcik will be requested when the pull request is marked ready for review matejcik is a code owner

prusnak Awaiting requested review from prusnak prusnak will be requested when the pull request is marked ready for review prusnak is a code owner

andrewkozlik Awaiting requested review from andrewkozlik andrewkozlik will be requested when the pull request is marked ready for review andrewkozlik is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet