change signatures to cosi #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the image validation signatures to use a custom CoSi-based implementation by replacing previous signature mechanisms with Trezor-crypto’s ed25519-donna sources and by hardcoding development keys for the time being.
- Added several new Trezor-crypto source files in boot/zephyr/CMakeLists.txt.
- Updated boot/bootutil/zephyr/CMakeLists.txt to include the new Trezor-crypto directory.
- Added a new file in boot/bootutil/trezor-crypto containing a relative path reference.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| boot/zephyr/CMakeLists.txt | Introduced new source files for Trezor-crypto and disabled precomputation for Ed25519. |
| boot/bootutil/zephyr/CMakeLists.txt | Added an include directory pointing to the Trezor-crypto sources. |
| boot/bootutil/trezor-crypto | Added a file with a relative path reference to the crypto directory. |
Comments suppressed due to low confidence (1)
boot/bootutil/zephyr/CMakeLists.txt:12
- Ensure that the relative path '../trezor-crypto' correctly resolves to the intended directory across all build configurations to prevent potential include path issues.
+ ../trezor-crypto
| @@ -0,0 +1 @@ | |||
| ../../../../../crypto | |||
There was a problem hiding this comment.
The file in boot/bootutil/trezor-crypto only contains a relative path reference. Consider using a symbolic link or adding documentation to clarify its purpose, as the current approach may lead to issues if the directory structure changes.
Suggested change
| ../../../../../crypto | |
| # This file has been replaced with a symbolic link to the crypto directory. | |
| # Purpose: To provide a stable reference to the crypto directory without relying on fragile relative paths. | |
| # Run the following command to create the symbolic link: | |
| # ln -s ../../../../../crypto boot/bootutil/trezor-crypto |
Copilot uses AI. Check for mistakes.
TychoVrahe
force-pushed
the
tychovrahe/sig/cosi
branch
from
26353ac to
96cf6ac
Compare
TychoVrahe
force-pushed
the
tychovrahe/sig/cosi
branch
from
96cf6ac to
19134f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies image_validation and only leaves custom, CoSi based signatures.
Dev keys are hardcoded for now.