Suse Manager Settings - Frontend refactoring #2819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDimonaco
changed the title
dottorblaster
approved these changes
Jul 26, 2024
EMaksy
approved these changes
Jul 26, 2024
| const [fetchError, setFetchError] = useState(false); | ||
| const [testingSettings, setTestingSettings] = useState(false); | ||
|
|
||
| const fetchSuseManagerSettings = async () => { |
There was a problem hiding this comment.
This is very clean, i like it :D
| ]); | ||
| }); | ||
|
|
||
| it('should test the suse manager settings and spawn a toast when the connection succeded', async () => { |
There was a problem hiding this comment.
typo in succeded --> succeeded 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes from redux state/sagas the suse manager settings.
This pr creates a custom hook to handle the lifecycle of suse manager settings.
UI/UX Interactions not changed.
How was this tested?
Automated tests