Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suse manager settings refactor #2788

Merged
merged 7 commits into from
Jul 16, 2024
Merged

Suse manager settings refactor #2788

merged 7 commits into from
Jul 16, 2024

Conversation

CDimonaco
Copy link
Member

@CDimonaco CDimonaco commented Jul 16, 2024 •
edited
Loading

Description

Naming and structural refactor of SUMACredentials.

The concept of SUMACredentials is replaced by SuseManagerSettings, this choice is made to unify all the settings under the same context settings and under the same controller/policy SettingsController/Settings.Policy

  • Suse manager settings moved under the settings context
  • Removed Suse credentials controller
  • Web actions of suse manager moved under settings controller
  • OpenApi renaming
  • New endpoints created under /settings/suse_manager, settings/suma_credentials endpoint marked as deprecated, backward compatibility guaranteed
  • Frontend consumes the new endpoints
  • Renamed suma credentials to suse manager settings through the whole codebase, tests included
  • Controller views unified

How was this tested?

Automated tests

@CDimonaco CDimonaco self-assigned this Jul 16, 2024
@CDimonaco CDimonaco added tech debt elixir Pull requests that update Elixir code labels Jul 16, 2024
@CDimonaco CDimonaco force-pushed the suse_manager_settings_refactor branch from 2df1d35 to 1d44504 Compare July 16, 2024 13:22
@CDimonaco CDimonaco marked this pull request as ready for review July 16, 2024 13:22
@CDimonaco CDimonaco force-pushed the suse_manager_settings_refactor branch from 1d44504 to 4233715 Compare July 16, 2024 13:24
arbulu89
arbulu89 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

assets/js/lib/api/softwareUpdatesSettings.js Outdated Show resolved Hide resolved
lib/trento_web/controllers/v1/settings_controller.ex Outdated Show resolved Hide resolved
lib/trento_web/router.ex Show resolved Hide resolved
dottorblaster
dottorblaster approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because he's the hero Gotham deserves, but not the one it needs right now. So we'll hunt him. Because he can take it. Because he's not our hero. He's a silent guardian, a watchful protector. A dark knight.

@CDimonaco CDimonaco merged commit c9c0024 into main Jul 16, 2024
26 checks passed
@CDimonaco CDimonaco deleted the suse_manager_settings_refactor branch July 16, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbulu89 arbulu89 arbulu89 approved these changes

@dottorblaster dottorblaster dottorblaster approved these changes

Assignees

@CDimonaco CDimonaco

Labels
elixir Pull requests that update Elixir code tech debt
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CDimonaco @dottorblaster @arbulu89