Open api spex object refactor #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Nice!
I'm not 100% what we "solve" with this exactly, except one decode function, as everything else remains untouched in essence
It's a pity that there is not any way to set struct? default value as false somehow.
Otherwise, we need to remember always to add the value, and it looks like something we can forget pretty easily. I hope we don't 😅
Maybe we could have our own macro for that
| @@ -116,7 +112,4 @@ defmodule TrentoWeb.V1.SUMACredentialsController do | |||
| end | |||
|
|
|||
| def get_policy_resource(_), do: Trento.SoftwareUpdates.Settings | |||
|
|
|||
| defp decode_body(body) when is_struct(body), do: Map.from_struct(body) | |||
There was a problem hiding this comment.
Is this the unique real place where we are forced to decode to map?
As far as I see, we can get the remaining fields exactly the same way without the struct? field
CDimonaco
force-pushed
the
open_api_spex_object_refactor
branch
from
2fb1833 to
732d355
Compare
CDimonaco
force-pushed
the
open_api_spex_object_refactor
branch
from
e8cf6de to
4e198f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR change the use of OpenApiSpex macro, to include
struct?:falseas parameter.This allow us to better pattern match into the controller action functions and also allow us to not decode the body_params into a map, and pass them directly to ecto, as phoenix convention.
The validation of the paramters and openapi definition remains untouched.
Other small controller fixes added.
Tested.