Angi architecture frontend #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
added
enhancement
arbulu89
force-pushed
the
angi-architecture-frontend
branch
from
6e9675e to
27a2a81
Compare
arbulu89
force-pushed
the
angi-architecture-frontend
branch
from
27a2a81 to
4aefb08
Compare
|
I like the implementation. Green Star for Angi 😃 |
EMaksy
approved these changes
Jul 11, 2024
| { arch: 'angi', tooltip: 'Angi architecture' }, | ||
| { arch: 'classic', tooltip: 'Classic architecture' }, | ||
| ])( | ||
| 'should show cluster type with $arch architecture', |
There was a problem hiding this comment.
To interpolate the value of arch value coming in the scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add architecture type visualization in the frontend, between
classicandangi. Only applicable for HANA clusters.Basically, a simple icon.
The icon is displayed in cluster details view, checks selection view and checks execution results view.
Besides that, the cluster checks selection filters checks with the current architecture (if the cluster is angi, only bring checks with this arch type, filtering out classic specific checks). Even though we don't have such a distinction by now...
How was this tested?
UT and storybook changes added