Link to patch detail #2741
Merged
Link to patch detail #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottorblaster
force-pushed
the
link-patch-detail
branch
2 times, most recently
from
63373db to
a3c3e96
Compare
dottorblaster
force-pushed
the
link-patch-detail
branch
from
a3c3e96 to
289274a
Compare
dottorblaster
force-pushed
the
link-patch-detail
branch
from
56568d8 to
121f28e
Compare
|
Please provide PR description |
|
@balanza I totally overlooked that, thank you |
jamie-suse
reviewed
Jul 11, 2024
| (buttonSize) => { | ||
| const content = faker.vehicle.vehicle(); | ||
| render( | ||
| <Button size={buttonSize} disabled> |
There was a problem hiding this comment.
Should the button be disabled here?
There was a problem hiding this comment.
LOL nope my bad, thanks
janvhs
approved these changes
Jul 11, 2024
jamie-suse
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
linkused to make standard effortless programmatic navigation without having to appease a11y guidelines every time