Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation tooltip on tag creation #2696

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Add validation tooltip on tag creation #2696

merged 6 commits into from
Jun 21, 2024

Conversation

balanza
Copy link
Member

@balanza balanza commented Jun 17, 2024

Description

Add a validation tooltip on tag creation. When the user type an unsupported character, the tooltip appears to communicate the failure; the tooltip disappears when adding a valid character.

ezgif-3-d916a02f2f

The feature is added to all editable tags in the application.

@balanza balanza requested review from nelsonkopliku and EMaksy June 17, 2024 17:17
@balanza balanza force-pushed the tooltip-on-tagging branch from c7e21d7 to d01b76c Compare June 17, 2024 17:28
@nelsonkopliku nelsonkopliku added the env Create an ephimeral environment for the pr branch label Jun 20, 2024
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@balanza thanks for this, it looks good. I noted a couple of things.

Besides that, I also noticed that the validation regex is not protecting against the following @_-=+,,...:::.
I know, you did not touch the regex. Up to you whether you want to make it stricter.

assets/js/common/Tags/Tags.stories.jsx Outdated Show resolved Hide resolved
assets/js/common/Tooltip/Tooltip.jsx Show resolved Hide resolved
@nelsonkopliku nelsonkopliku removed the env Create an ephimeral environment for the pr branch label Jun 20, 2024
@balanza
Copy link
Member Author

balanza commented Jun 21, 2024

Besides that, I also noticed that the validation regex is not protecting against the following @_-=+,,...:::.
I know, you did not touch the regex. Up to you whether you want to make it stricter.

@nelsonkopliku to be honest I thought it was the intended behavior. It costs me 1min to fix, beside that I prefer to have a dedicate PR (and issue) so that we can share and discuss any possible problems (e.g. that would make tags non-retrocompatibles). It sounds?

@balanza balanza force-pushed the tooltip-on-tagging branch from 3fb66a8 to 9530fad Compare June 21, 2024 16:02
@nelsonkopliku nelsonkopliku self-requested a review June 21, 2024 16:11
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @balanza! I am fine with a possible follow up on the regex, if needed.

@balanza balanza force-pushed the tooltip-on-tagging branch 2 times, most recently from 73f568f to afa646b Compare June 21, 2024 16:28
balanza added 6 commits June 21, 2024 19:01
Signed-off-by: balanza <[email protected]>
Signed-off-by: balanza <[email protected]>
Signed-off-by: balanza <[email protected]>
Signed-off-by: balanza <[email protected]>
@balanza balanza force-pushed the tooltip-on-tagging branch from afa646b to 662a64c Compare June 21, 2024 17:01
@balanza balanza merged commit 342b5ca into main Jun 21, 2024
11 checks passed
@balanza balanza deleted the tooltip-on-tagging branch June 21, 2024 17:01
@nelsonkopliku nelsonkopliku added enhancement New feature or request user story javascript Pull requests that update Javascript code labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code user story
Development

Successfully merging this pull request may close these issues.

2 participants