-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation tooltip on tag creation #2696
Conversation
c7e21d7
to
d01b76c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@balanza thanks for this, it looks good. I noted a couple of things.
Besides that, I also noticed that the validation regex is not protecting against the following @_-=+,,...:::
.
I know, you did not touch the regex. Up to you whether you want to make it stricter.
@nelsonkopliku to be honest I thought it was the intended behavior. It costs me 1min to fix, beside that I prefer to have a dedicate PR (and issue) so that we can share and discuss any possible problems (e.g. that would make tags non-retrocompatibles). It sounds? |
3fb66a8
to
9530fad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @balanza! I am fine with a possible follow up on the regex, if needed.
73f568f
to
afa646b
Compare
Signed-off-by: balanza <[email protected]>
Signed-off-by: balanza <[email protected]>
Signed-off-by: balanza <[email protected]>
Signed-off-by: balanza <[email protected]>
Signed-off-by: balanza <[email protected]>
Signed-off-by: balanza <[email protected]>
afa646b
to
662a64c
Compare
Description
Add a validation tooltip on tag creation. When the user type an unsupported character, the tooltip appears to communicate the failure; the tooltip disappears when adding a valid character.
The feature is added to all editable tags in the application.