Watch channel events #2692
Merged
Watch channel events #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
force-pushed
the
watch-channel-events
branch
3 times, most recently
from
8ded7ae to
60af319
Compare
dottorblaster
approved these changes
Jun 14, 2024
arbulu89
force-pushed
the
watch-channel-events
branch
from
60af319 to
6f8730a
Compare
arbulu89
force-pushed
the
watch-channel-events
branch
from
6f8730a to
efc1c7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor how we watch websocket events using a eventChannel.
This is the correct way to listen external events.
Big benefits:
How was this tested?
Test added. I have created a mocked version of the phoenix sockets. It looks minimalist enough