Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add software updates settings schema #2234

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Jan 30, 2024

Description

Initial PR supporting SUMA settings API.
Simply adding a schema where required information are going to be stored.

Consider that:

Implementation of module to get/apply suma settings will follow.

How was this tested?

Manually by running migration and manual insertions. More thorough testing will follow when implementing the context (service)

@nelsonkopliku nelsonkopliku self-assigned this Jan 31, 2024
@nelsonkopliku nelsonkopliku added enhancement New feature or request user story elixir Pull requests that update Elixir code labels Jan 31, 2024
@nelsonkopliku nelsonkopliku force-pushed the suma-settings-schema branch 2 times, most recently from 9597d2b to b265aa7 Compare January 31, 2024 15:58
@nelsonkopliku nelsonkopliku marked this pull request as ready for review January 31, 2024 16:04
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor nitpick

@nelsonkopliku nelsonkopliku merged commit 9e3c642 into main Feb 1, 2024
23 checks passed
@nelsonkopliku nelsonkopliku deleted the suma-settings-schema branch February 1, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Pull requests that update Elixir code enhancement New feature or request user story
Development

Successfully merging this pull request may close these issues.

3 participants