Project host FQDN

[dottorblaster]

Description

Project the FQDN sent by the agent on the host read model.

How was this tested?

Existing unit tests updated

[jamie-suse]

LGTM 🚀

[nelsonkopliku]

I am afraid we're missing some parts of the changing fqdn scenario.

During a host's restoration
in execute on line 173 we also need to match the fqdn between the aggregate's state and the incoming RegisterHost command, meaning that the exact same host has been restored and so only a HostRestored is emitted

During a host's details changes detection
in executes on lines 259 and 284 fqdn is not properly taken into account.
In the first command handling we need to match also fqdn between aggregate's state and the incoming RegisterHost so that if they're the same no event is emitted.
In the second command handling, when the previous does not match (aka different details have been detected), we need to get the fqdn from the incoming RegisterHost command and emit it in HostDetailsUpdated (and of course update aggregate's state accordingly in the relevant apply)

Happy to answer any questions.

[dottorblaster]

@nelsonkopliku thanks for catching that! About changes detection: totally right, I updated the code accordingly.

About restoration: not a big fan of matching the FQDN in that clause because I don't think it's a relevant detail to base the restoration logic upon, but I don't have a strong opinion either. Change done. 👍

[nelsonkopliku]

@dottorblaster the problem with restoration is that if all other details remain unchanged, BUT fully_qualified_domain_name does change, we are yes going to have a HostRestored event emitted, but not a HostDetailsUpdated resulting in a dirty state both in the aggregate and in the read models.

[EDIT] I guess some tests for the changing fqdn scenario are necessary

[dottorblaster]

@nelsonkopliku added a test for a changing FQDN scenario and enriched already existing expectations to include some more fqdn infos.

[nelsonkopliku]

Everything looks fine now, thanks!
We might want to have at least one photofinish scenario sending the fqdn, for completeness.