Upgrade elixir 1.15.7 otp 26 #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
force-pushed
the
upgrade-elixir-1.15.7-otp-26
branch
3 times, most recently
from
1425526 to
1f7e72e
Compare
arbulu89
force-pushed
the
upgrade-elixir-1.15.7-otp-26
branch
from
1f7e72e to
3902781
Compare
arbulu89
commented
Jan 17, 2024
| with: | ||
| name: openapi-diff-report-${{ matrix.version }} | ||
| path: specs/ | ||
| # - name: Generate main openapi.json |
There was a problem hiding this comment.
I'm forced to comment this stage out.
We cannot compare specs written in 2 different elixir versions.
Commenting this looks the less invasive way.
I will revert back once this PR is merged
There was a problem hiding this comment.
Absolutely plus one, no problem for me
arbulu89
force-pushed
the
upgrade-elixir-1.15.7-otp-26
branch
from
3902781 to
ed303e3
Compare
arbulu89
requested review from
dottorblaster,
rtorrero,
nelsonkopliku,
CDimonaco,
EMaksy and
jamie-suse
nelsonkopliku
approved these changes
Jan 18, 2024
CDimonaco
approved these changes
Jan 18, 2024
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade elixir to 1.15.7 and erlang to OTP26 version, in order to match with packages provided in SUSE (by now tumbleweed).
I have taken advantage of updating the dependencies as well.
Note: The
api_keytests were updated to use new keys, as the erlang crypto module has changed the signing strategy. Even in this case, the oldapi_keysare valid to validate, so it is a non op for the user. They will see a different key in the frontend settings page, that's truePD: To change the dockerfiles. They need some more work
PD2: For some reason the command
mix do ecto.drop, event_store.drop, ecto.create, ecto.migrate, setupis raising an error. I needed to runmix setupseparately afterwards to make it work.How was this tested?
Current tests