Add ENSA version info to Checks execution

[jamie-suse]

Description

Adds ENSA version info to Checks execution.

How was this tested?

Added unit tests.

[jamie-suse]

There is an existing enum Trento.SapSystems.Enums.EnsaVersion, however it does not contain a value for :mixed_versions. Should I create a new enum under Trento.Clusters.Enums.EnsaVersion that reflects this?

[nelsonkopliku]

There is an existing enum Trento.SapSystems.Enums.EnsaVersion, however it does not contain a value for :mixed_versions. Should I create a new enum under Trento.Clusters.Enums.EnsaVersion that reflects this?

ensa version is a specificity of SapSystems, however its mixed_versions nuance is peculiar to a cluster managing sap application instances.
We could indeed have a cluster specific EnsaVersion enum.
I am thinking of what could go wrong, but I don't see blockers.

[nelsonkopliku]

Just a tiny thing in cluster_execution_env.ex: we need to use the correct EnsaVersion enum.

Besides that, LGTM.

[nelsonkopliku]

Great, thanks!

[dottorblaster]

One little thing then we can merge

[dottorblaster]

Suggested change

	case length(ensa_versions) do
	1 -> Enum.at(ensa_versions, 0)
	_ -> EnsaVersion.mixed_versions()
	end
	case ensa_versions do
	[ensa_version] -> ensa_version
	_ -> EnsaVersion.mixed_versions()
	end

You can leverage Elixir's declarative approach even more 👍

[jamie-suse]

Thanks! I was trying to figure out how to do essentially this 😆 looks a lot better 👍

[dottorblaster]

LGTM, great job 👍