Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sequence usage in sles subscription factory #2164

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

dottorblaster
Copy link
Contributor

Description

Sometimes we build lists of SLES subscriptions using the factory we have, that doesn't use sequences to assign different numbers to the identifier field which is actually a part of a primary key.

Given this, the problem we're incurring into is that our unit tests pipeline runs into collisions. This change should fix that.

How was this tested?

Existing tests passing

Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👀

@dottorblaster dottorblaster marked this pull request as ready for review January 11, 2024 14:57
@dottorblaster dottorblaster merged commit 3d2ed21 into main Jan 11, 2024
28 checks passed
@dottorblaster dottorblaster deleted the fix-sles-subscription-sequence-behavior branch January 11, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants