Add warning icon on not installed saptune version only if sap workloa…

…d is present
trento-project · Jan 23, 2024 · aaf4629 · aaf4629
1 parent aceba03
commit aaf4629
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/assets/js/pages/HostDetailsPage/HostDetails.jsx b/assets/js/pages/HostDetailsPage/HostDetails.jsx
@@ -68,7 +68,7 @@ function HostDetails({
   const [cleanUpModalOpen, setCleanUpModalOpen] = useState(false);
 
   const versionWarningMessage = agentVersionWarning(agentVersion);
-
+  const isSapPresent = sapInstances.length > 0;
   const saptuneVersion = get(saptuneStatus, 'package_version');
   const saptuneConfiguredVersion = get(saptuneStatus, 'configured_version');
   const saptuneTuning = get(saptuneStatus, 'tuning_state');
@@ -193,6 +193,7 @@ function HostDetails({
           />
           <div className="flex flex-col mt-4 bg-white shadow rounded-lg pt-8 px-8 xl:w-2/5 mr-4">
             <SaptuneSummary
+              isSapPresent={isSapPresent}
               saptuneVersion={saptuneVersion}
               saptuneConfiguredVersion={saptuneConfiguredVersion}
               saptuneTuning={saptuneTuning}

diff --git a/assets/js/pages/HostDetailsPage/SaptuneSummary.jsx b/assets/js/pages/HostDetailsPage/SaptuneSummary.jsx
@@ -7,6 +7,7 @@ import ListView from '@common/ListView';
 import { SaptuneVersion, SaptuneTuningState } from '@pages/SaptuneDetails';
 
 function SaptuneSummary({
+  isSapPresent,
   saptuneVersion,
   saptuneConfiguredVersion,
   saptuneTuning,
@@ -32,7 +33,12 @@ function SaptuneSummary({
         data={[
           {
             title: 'Package',
-            content: <SaptuneVersion version={saptuneVersion} />,
+            content: (
+              <SaptuneVersion
+                isSapPresent={isSapPresent}
+                version={saptuneVersion}
+              />
+            ),
           },
           {
             title: 'Tuning',

diff --git a/assets/js/pages/SaptuneDetails/SaptuneVersion.jsx b/assets/js/pages/SaptuneDetails/SaptuneVersion.jsx
@@ -5,11 +5,11 @@ import { isVersionSupported, SUPPORTED_VERSION } from '@lib/saptune';
 import Tooltip from '@common/Tooltip';
 import HealthIcon from '@common/HealthIcon';
 
-function SaptuneVersion({ version }) {
+function SaptuneVersion({ version, isSapPresent = true }) {
   if (!version) {
     return (
       <div className="flex">
-        <HealthIcon health="warning" />
+        {isSapPresent ? <HealthIcon health="warning" /> : null}
         <span className="ml-1">Not installed</span>
       </div>
     );