Skip to content

Commit

Permalink
Upgrade Node.js to version 20.14.0 LTS (#2660)
Browse files Browse the repository at this point in the history
* Upgrade Node.js to version 20.14.0 LTS

This commit upgrade the Node.js version to 20.14.0.

I am running this for several weeks on my MacBook Air M2 and it works
without any problems. This will allow us to upgrade Sotorybook and
ESLint, once all our ESLint plugins are compatible with ESLint 9.

* Update Node.js in GitHub CI

This brings the CI up to the same version used in the development and
release environment.

* Update npm for the trento-web RPM

This commit replaces the npm version for the RPM, to use node v20's
version of npm.
  • Loading branch information
janvhs authored Jul 1, 2024
1 parent cb48bef commit 95def23
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:

env:
MIX_ENV: test
NODE_VERSION: "16"
NODE_VERSION: "20"
MANTAINERS: '["cdimonaco", "dottorblaster", "janvhs", "rtorrero", "nelsonkopliku", "arbulu89","jagabomb","emaksy","jamie-suse"]'
RG_TEST_LABEL: regression

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: "16"
node-version: "20"
cache: "npm"
cache-dependency-path: test/e2e/package-lock.json
- name: Checkout terraform repo
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
elixir 1.15.7-otp-26
erlang 26.2.1
nodejs 16.16.0
nodejs 20.14.0
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ARG MIX_ENV=prod
ENV MIX_ENV=$MIX_ENV
RUN mix deps.get

FROM registry.suse.com/bci/nodejs:16 AS assets-build
FROM registry.suse.com/bci/nodejs:20 AS assets-build
COPY --from=elixir-build /build /build
WORKDIR /build/assets
RUN npm install
Expand Down
2 changes: 1 addition & 1 deletion guides/development/hack_on_the_trento.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ In order to run the Trento Web application, the following software must be insta

1. [Elixir](https://elixir-lang.org/) - 1.15.7 preferred
2. [Erlang OTP](https://www.erlang.org/) - 26.1.2 preferred
3. [Node.js](https://nodejs.org/en/) - 16.16.0 preferred
3. [Node.js](https://nodejs.org/en/) - 20.14.0 preferred
4. [Docker](https://docs.docker.com/get-docker/)
5. [Docker Compose](https://docs.docker.com/compose/install/)

Expand Down
2 changes: 1 addition & 1 deletion packaging/suse/container/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#!UseOBSRepositories
#!ExclusiveArch: x86_64

FROM bci/nodejs:16 AS assets-build
FROM bci/nodejs:20 AS assets-build
ADD web.tar.gz /build/
WORKDIR /build/web/assets
RUN npm run tailwind:build
Expand Down
4 changes: 2 additions & 2 deletions packaging/suse/rpm/trento-web.spec
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Source2: package-lock.json
Source3: node_modules.spec.inc
%include %{_sourcedir}/node_modules.spec.inc
Group: System/Monitoring
BuildRequires: elixir >= 1.15, elixir-hex, npm16, erlang-rebar3, git-core, local-npm-registry, make, gcc
BuildRequires: elixir >= 1.15, elixir-hex, npm20, erlang-rebar3, git-core, local-npm-registry, make, gcc

%description
Trento is an open cloud-native web application for SAP Applications administrators.
Expand Down Expand Up @@ -83,4 +83,4 @@ install -D -m 0600 packaging/suse/rpm/systemd/trento-web.example %{buildroot}/et
%license LICENSE
%doc README.md guides

%changelog
%changelog

0 comments on commit 95def23

Please sign in to comment.